Who has made better films, The Rock or Vin Diesel?

Vin Diesel was in Saving Private Ryan. Not sure if The Rock has been in anything as memorable as that.

The OP asked who has made better films implying who was the star, not who happened to be cast in a movie by other people. That said Vin was in Pitch Black so he might still have the edge. Then again Diesel has been in many, many more bad movies.

You can't count Saving Private Ryan because Vin Diesel was a nobody at that time and he has a very small role. By no means is it a Vin Diesel vehicle. It's a tough call, they have two of the strangest careers I can think of as far as A list action heroes go. Johnson's movies have all sucked as far as I'm concerned, whereas every Diesel movie I'd call a success has had an ensemble cast (Pitch Black, the Fast & Furious franchise, his voicework in the MCU). Diesel is the headliner in the Furious franchise but he's not carrying it. There's a difference. (All this is beside the fact that I think the Furious films are terrible.) When you look at his 'solo' career, i.e. action movies where he's supposed to be doing all the heavy lifting, (XXX franchise, the rest of the Riddick franchise, Babylon AD, The Last Witchhunter-- this unwatchable list goes on and on...), you have to say the guy is a failure as a solo action hero.

They've both done dopey comedies and R rated crime action/dramas that were quickly forgotten, so no real advantage to either of them there. I can't think of a single good movie that Dwayne Johnson has been a major part of. I guess Diesel wins by default. Pitch Black is great, he's been a small part of the success of GOTG and the Iron Giant (voicework only, and again with GOTG it's an ensemble cast).

What's stranger, at least to me: I like both of these guys. I've been trashing their careers the entire time in this post, but I don't think it's a lack of talent on their part. They just seem to pick the wrong projects. Johnson always should've been the next Schwarzenegger, but for whatever reason he's the king of PG-13 actioners instead. It surely has more to do with industry trends than creative choices on his part. Diesel doesn't shy away from darker stuff, but it's always just plain horrible material.

Bottom line, I think both of them need better agents.

Since the title is about who's made better films - not specifying how large their role had to be - I'm gonna ignore the naysayers and count Saving Private Ryan and Guardians 1/2 as Vinny D movies. Not to mention the 90s animated masterpiece, The Iron Giant.

The Rock is generally the best thing about the movies he's in, including the Fast/Furious franchise itself, the movies are generally weak outside of him. The only Rock movies I actually enjoy are said Fast movies (also starring Diesel) and The Rundown. Neither of which are The Iron Giant.

Vin Diesel, as he has "Boiler Room" and "Find Me Guilty" in his filmography.

Dwayne Johnson is very charismatic and has found a nice niche for himself in some fun films, though.

I've seen a dozen Rock movies; the only one that has come close to ok viewing is a crime thriller called snitch (2013). Then there's southland tales, which if not particularly successful, is at least non routine. I started the Jumanji sequel recently - 20 minutes was enough of that, thanks.

Vin Diesel's lineup of movies isn't a huge improvement, but it is better. The sequel fast & furious (2009) is the pick for him, if only because the film actually lives up to it's name.

I've enjoyed more Rock movies.

He's got the charisma Diesel lacks.

Tough call for me. I adore Dwayne Johnson and I think he's smart about the films he does. He's also incredibly gracious to his fans, and that motivates me to support his work.

I enjoy Vin Deisel's stuff, and he is Groot...soooo

I don't know?!!! I can't decide.

As a lifelong wrestling fan, I recognise Rock's dominant period in the ring, but for cinema, I'd like to go with Diesel. Thanks.